Re: Add two missing tests in 035_standby_logical_decoding.pl - Mailing list pgsql-hackers

Hi,

On 5/9/23 8:02 AM, Amit Kapila wrote:
> On Mon, May 8, 2023 at 1:45 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:

> 
> Why not initialize the cascading standby node just before the standby
> promotion test: "Test standby promotion and logical decoding behavior
> after the standby gets promoted."? That way we will avoid any unknown
> side-effects of cascading standby and it will anyway look more logical
> to initialize it where the test needs it.
> 

Yeah, that's even better. Moved the physical slot creation on the standby
and the cascading standby initialization where "strictly" needed in V2
attached.

Also ensuring that hsf is set to on on the cascading standby to be on the
safe side of thing.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com