Re: Ordering of header file inclusion - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Ordering of header file inclusion
Date
Msg-id 5ef44524-371d-6036-8616-9f04df33c92b@2ndquadrant.com
Whole thread Raw
In response to Re: Ordering of header file inclusion  (vignesh C <vignesh21@gmail.com>)
Responses Re: Ordering of header file inclusion
Re: Ordering of header file inclusion
List pgsql-hackers
diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c
index f9fe57f..6224735 100644
--- a/contrib/bloom/blcost.c
+++ b/contrib/bloom/blcost.c
@@ -12,10 +12,10 @@
  */
 #include "postgres.h"

+#include "bloom.h"
 #include "fmgr.h"
 #include "utils/selfuncs.h"

-#include "bloom.h"

 /*
  * Estimate cost of bloom index scan.

This class of change I don't like.

The existing arrangement keeps "other" header files separate from the
header file of the module itself.  It seems useful to keep that separate.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pause recovery if pitr target not reached
Next
From: Tom Lane
Date:
Subject: Re: Backport "WITH ... AS MATERIALIZED" syntax to <12?