Re: [HACKERS] Setting pd_lower in GIN metapage - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] Setting pd_lower in GIN metapage
Date
Msg-id 5e07495c-fd4c-2ea6-be3e-1712a9ee469d@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Setting pd_lower in GIN metapage  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Setting pd_lower in GIN metapage
List pgsql-hackers
On 2017/09/13 16:20, Michael Paquier wrote:
> On Wed, Sep 13, 2017 at 2:48 PM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> I updated the patches so that the metapage's pd_lower is set to the
>> correct value just before *every* point where we are about to insert a
>> full page image of the metapage into WAL.  That's in addition to doing the
>> same in various metapage init routines, which the original patch did
>> already anyway.  I guess this now ensures that wal_consistency_checking
>> masking of these metapages as standard layout pages always works, even for
>> pre-v11 indexes that were upgraded.
> 
> Please note that I do have plans to look at all the patches proposed
> on this thread for all the indexes next. No report for today though as
> those deal with many code paths so it requires some attention. I think
> I'll group the review for all index AMs into the same email if you
> don't mind, each patch deals with its own thing in its own
> src/backend/access/ path.

Sure, no problem.

Thanks,
Amit



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] no test coverage for ALTER FOREIGN DATA WRAPPER nameHANDLER ...
Next
From: Alexey Chernyshov
Date:
Subject: Re: [HACKERS] [PATCH] Pageinspect - add functions on GIN and GiSTindexes from gevel