Re: Should we add a compiler warning for large stack frames? - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Should we add a compiler warning for large stack frames?
Date
Msg-id 5dcf817e-beef-423e-8a43-615fd960638d@dunslane.net
Whole thread Raw
In response to Re: Should we add a compiler warning for large stack frames?  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers


On 2024-04-11 Th 16:17, Andres Freund wrote:
128k is probably not going to be an issue in practice. However, it also seems
not great from a performance POV to use this much stack in a function that's
called fairly often.  I'd allocate the buffer in verify_backup_checksums() and
reuse it across all to-be-checked files.



Yes, I agree. I'll make that happen in the next day or two.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: post-freeze damage control
Next
From: Tomas Vondra
Date:
Subject: Re: Add notes to pg_combinebackup docs