Re: Failure in contrib test _int on loach - Mailing list pgsql-hackers

From Anastasia Lubennikova
Subject Re: Failure in contrib test _int on loach
Date
Msg-id 5d48ce28-34cf-9b03-5d42-dbd5457926bf@postgrespro.ru
Whole thread Raw
In response to Re: Failure in contrib test _int on loach  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Failure in contrib test _int on loach
Re: Failure in contrib test _int on loach
List pgsql-hackers
27.04.2019 22:05, Tom Lane wrote:
> Anastasia Lubennikova <a.lubennikova@postgrespro.ru> writes:
>> So it is possible, but it doesn't require any extra algorithm changes.
>> I didn't manage to generate dataset to reproduce grandparent split.
>> Though, I do agree that it's worth checking out. Do you have any ideas?
> Ping?  This thread has gone cold, but the bug is still there, and
> IMV it's a beta blocker.

Hi,

Thank you for the reminder.
In a nutshell, this fix is ready for committer.

In previous emails, I have sent two patches with test and bugfix (see 
attached).
After Heikki shared his concerns, I've rechecked the algorithm and 
haven't found any potential error.
So, if other hackers are agreed with my reasoning, the suggested fix is 
sufficient and can be committed.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Refactoring the checkpointer's fsync request queue
Next
From: Daniel Gustafsson
Date:
Subject: Re: Plain strdup() in frontend code