Re: Proposal to introduce a shuffle function to intarray extension - Mailing list pgsql-hackers

From Martin Kalcher
Subject Re: Proposal to introduce a shuffle function to intarray extension
Date
Msg-id 5b7a1ee9-f942-2502-3a0c-e9fc12511139@aboutsource.net
Whole thread Raw
In response to Re: Proposal to introduce a shuffle function to intarray extension  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Proposal to introduce a shuffle function to intarray extension
List pgsql-hackers
Am 18.07.22 um 00:46 schrieb Tom Lane:
> 
> This does not look particularly idiomatic, or even type-safe.  What you
> should have done was use deconstruct_array to get an array of Datums and
> isnull flags, then shuffled those, then used construct_array to build the
> output.
> 
> (Or, perhaps, use construct_md_array to replicate the input's
> precise dimensionality.  Not sure if anyone would care.)
> 
>             regards, tom lane

deconstruct_array() would destroy the arrays dimensions. I would expect 
that shuffle() only shuffles the first dimension and keeps the inner 
arrays intact.

Martin



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal to introduce a shuffle function to intarray extension
Next
From: "Dian M Fay"
Date:
Subject: Re: doc: Make selectivity example match wording