On Sat, Oct 4, 2025, at 11:29 PM, PG Bug reporting form wrote:
> In function _SPI_execute_plan(), `my_tuptable` is local variable and
> initialized as NULL.
> If plan is canSetTag subqueries, `SPI_freetuptable(my_tuptable)` is
> meaningless, because `my_tuptable` is NULL.
> We'd better remove this code.
>
There could be multiple statements. The first case will call SPI_freetuptable()
and it is a noop. The code path you are referring to is inside a foreach loop
and a previous statement might set my_tuptable and needs to be freed before
reusing it. That's exactly what the comment says.
/*
* The last canSetTag query sets the status values returned to the
* caller. Be careful to free any tuptables not returned, to
* avoid intra-transaction memory leak.
*/
if (canSetTag)
{
my_processed = _SPI_current->processed;
SPI_freetuptable(my_tuptable);
my_tuptable = _SPI_current->tuptable;
my_res = res;
}
--
Euler Taveira
EDB https://www.enterprisedb.com/
