Re: proposal: alternative psql commands quit and exit - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: proposal: alternative psql commands quit and exit
Date
Msg-id 5a5ee419-0785-9629-b4ce-888442634545@2ndquadrant.com
Whole thread Raw
In response to Re: proposal: alternative psql commands quit and exit  (Stephen Frost <sfrost@snowman.net>)
Responses Re: proposal: alternative psql commands quit and exit
Re: proposal: alternative psql commands quit and exit
List pgsql-hackers
On 01/13/2018 10:52 PM, Stephen Frost wrote:
> Vik, all,
> 
> * Vik Fearing (vik.fearing@2ndquadrant.com) wrote:
>> On 01/09/2018 02:29 AM, Alvaro Herrera wrote:
>>> Everaldo Canuto wrote:
>>>> Change my patch will make psql different from other sql clients I use
>>>> (sqlplus and mysql).
>>>
>>> Well, I don't think we're too hot about copying their behavior exactly.
>>> This thread discussed the behavior at length and a consensus was found
>>> after much thinking.  No one is imposing anything.
>>>
>>>> I am happy with my custom version of psql so you can cancel/delete/ignore
>>>> my patch.
>>>
>>> We're not happy to lose a potential contributor, but of course that's
>>> your prerogative.
>>>
>>> Can we find somebody else willing to implement the agreed-upon behavior?
>>
>> I'm currently reviewing two other patches in the commitfest (in my
>> limited time).  When I'm done with those I would be happy to pick this
>> up if no one else has.
> 
> Looks like the status of this should really be 'waiting on author' (even
> if the current author isn't really interested in updating it, sounds
> like Vik might be), so I've adjusted its status.
> 
> I'm also of the opinion that this would be good to have, though I don't
> know that I'll have time to bring it over the line for v11.

After re-reading the thread, I think the original patch is optimal.  I
don't like what the consensus is and so I have no interest in
implementing it.

In particular, I currently hate how pasting a query with tabs screws
everything up with unhelpful completions.  I don't want to add to that
with the column example Tom exposed in [1] and especially with the
plpgsql example Vladimir Svedov exposed in [2].

I quite like the idea of blanking the database name in PROMPT2 as
suggested by Daniel in [3], I would be happy to work on that patch if
others agree.

[1] https://postgr.es/m/31478.1512760025@sss.pgh.pa.us

[2]
https://postgr.es/m/CADqDLE-hgRA0qLeiC3a3DJ41-yR5kj=k0o679K=zk32VLzaB1Q@mail.gmail.com

[3]
https://postgr.es/m/ad75eab6-71ea-4e1f-8aa5-68876ff50651@manitou-mail.org
-- 
Vik Fearing                                          +33 6 46 75 15 36
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: WIP: a way forward on bootstrap data
Next
From: Stephen Frost
Date:
Subject: Re: proposal: alternative psql commands quit and exit