Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum
Date
Msg-id 5EE46627-6B9A-4967-B009-7693CB52482F@yandex-team.ru
Whole thread
In response to Restore vacuum_delay_point() in GIN posting-tree leaf vacuum  (Paul Kim <mok03127@gmail.com>)
Responses Re: Proposal: Conflict log history table for Logical Replication
List pgsql-hackers

> On 23 Jul 2026, at 00:28, Alexander Korotkov <aekorotkov@gmail.com> wrote:
>
> On Mon, Jul 20, 2026 at 10:10 PM Andrey Borodin <x4mmm@yandex-team.ru> wrote:
>>
>>> On 20 Jul 2026, at 16:59, Alexander Korotkov <aekorotkov@gmail.com> wrote:
>>>
>>> We're holding cleanup lock on posting tree root while
>>> ginScanPostingTreeToDelete(), not ginVacuumPostingTreeLeaves().  So, I
>>> think yes, vacuum_delay_point() was deleted unintentionally.
>>
>> Yup, my recollection was wrong. ginVacuumPostingTreeLeaves() seems fine for a
>> delay point.
>
> Please, check the patch attached.

I'm slightly against mentioning corruption in the commit message for two reasons:
1. With corruption any effect is possible
2. We are not dealing with corruption here, fortunately

Besides this patch LGTM. Thanks!


Best regards, Andrey Borodin.


Attachment

pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: log_postmaster_stats
Next
From: Alexandre Felipe
Date:
Subject: Re: SLOPE - Planner optimizations on monotonic expressions.