Re: amcheck: add index-all-keys-match verification for B-Tree - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: amcheck: add index-all-keys-match verification for B-Tree
Date
Msg-id 5AC2156E-AC9B-4D07-AC6C-D5D5AF5DBD35@yandex-team.ru
Whole thread
In response to amcheck: add index-all-keys-match verification for B-Tree  (Andrey Borodin <x4mmm@yandex-team.ru>)
List pgsql-hackers
Jakub, thanks for the next review round! I'll provide thoughtful answers later.
Here's some context:

> On 27 Jul 2026, at 17:15, Jakub Wartak <jakub.wartak@enterprisedb.com> wrote:
>
>> One thing still on my TODO list for a next version: the key
>> comparison relies on bt_normalize_tuple(), and normalization has
>> historically been a rich source of subtle bugs for heapallindexed
>> (TOAST compression differences, and a whole series of follow-up
>> fixes for various datum representations).[..]
>
> It's way outside of my typical area, can You please share some sample pointer or
> link?

e.g. see  ab65dfb0fb2, eba775345d2, b1fe8efdf1.
The thing is index key fingerprint might be different under different circumstances.

Thanks!


Best regards, Andrey Borodin.

[0] https://github.com/postgres/postgres/commit/ab65dfb0fb2
[1] https://github.com/postgres/postgres/commit/eba775345d2
[2] https://github.com/postgres/postgres/commit/b1fe8efdf17


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: POC: PLpgSQL FOREACH IN JSON ARRAY
Next
From: Tom Lane
Date:
Subject: Re: remove_useless_joins vs. bug #19560