Re: [PG19]pg_verifybackup never finishes on a gzip-compressed tar backup - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PG19]pg_verifybackup never finishes on a gzip-compressed tar backup
Date
Msg-id 59d54b10-ceb5-41b4-a04b-c7d844c7d177@dunslane.net
Whole thread
In response to Re: [PG19]pg_verifybackup never finishes on a gzip-compressed tar backup  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: [PG19]pg_verifybackup never finishes on a gzip-compressed tar backup
List pgsql-hackers
On 2026-10-07 We 8:48 PM, Chao Li wrote:
>
>> On Oct 7, 2026, at 19:44, Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 6 Oct 2026, at 03:48, shihao zhong <zhong950419@gmail.com> wrote:
>>> I took a look at the code and I think we are solving different problems.
>> I concur that this is a separate issue.  Today I returned to looking at the
>> truncation patchset and I am including this fix in that review effort.
>>
>> --
>> Daniel Gustafsson
>>
> Sorry for the confusion. I was on vacation and didn’t look into the patch closely.
>
> This seems to be an old bug that couldn’t be triggered before PG19 (b15c1513984 added tar support to pg_waldump). So,
Iagree with Melanie that this should be an 19 open item.
 
>
> The patch calls inflateReset() after each member finishes, allowing decompression to continue with the next member,
whichlooks like a correct fix to me.
 
>

Yes, looks good to me. I will commit later today.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Raja Sai pranav
Date:
Subject: Re: Add a hint to the "WAL summaries are required" errors
Next
From: Greg Burd
Date:
Subject: Re: Let an ordering index scan hand its ORDER BY value to the target list