On 04/07/2018 04:37 PM, Teodor Sigaev wrote:
>> by this patch. Revised version is attached.
>
> Fine, patch got several rounds of review in all its parts. Is any
> places which should be improved before commit?
>
I personally feel rather uneasy about committing it, TBH.
While I don't see any obvious issues in the patch at the moment, the
recent changes were rather significant so I might easily miss some
unexpected consequences. (OTOH it's true it was mostly about reduction
of scope, to limit the risks.)
I don't have time to do more review and testing on the latest patch
version, unfortunately, certainly not before the CF end.
So I guess the ultimate review / decision is up to you ...
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
