Re: [HACKERS] Substantial bloat in postgres_fdw regression test runtime - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Substantial bloat in postgres_fdw regression test runtime
Date
Msg-id 5995.1485351168@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Substantial bloat in postgres_fdw regression test runtime  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> writes:
> On Thu, Nov 3, 2016 at 1:58 PM, Jeevan Chalke
> <jeevan.chalke@enterprisedb.com> wrote:
>> Attached patch with test-case modification.

> I verified that this patch indeed bring the time down to 2 to 3
> seconds from 10 seconds.

Thanks for working on this, guys.

> The additional condition t2.c2 = 6 seems to echo the filter t2.c2 = 6
> of aggregate. We wouldn't know which of those actually worked. I
> modified the testcase to use t2.c2 % 6 = 0 instead and keep the filter
> condition intact. This increases the execution time by .2s, which may
> be ok. Let me know what you thing of the attached patch.

Agreed, that seems like a good compromise.  Pushed that way.

> Also, please add this to the commitfest, so that it isn't forgotten.

No need.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Proposal : For Auto-Prewarm.
Next
From: David Fetter
Date:
Subject: Re: [HACKERS] COPY as a set returning function