Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+ - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+
Date
Msg-id 5948.1291685894@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+  (Josh Berkus <josh@agliodbs.com>)
Responses Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+  (Andrew Dunstan <andrew@dunslane.net>)
Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+  (Josh Berkus <josh@agliodbs.com>)
Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Josh Berkus <josh@agliodbs.com> writes:
> Making it support O_DIRECT would be possible but more complex; I don't
> see the point unless we think we're going to have open_sync_with_odirect
> as a seperate option.

Whether it's complex or not isn't really the issue.  The issue is that
what test_fsync is testing had better match what the backend does, or
people will be making choices based on not-comparable test results.
I think we should have test_fsync just automatically fold in O_DIRECT
the same way the backend does.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: We really ought to do something about O_DIRECT and data=journalled on ext4
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Revert default wal_sync_method to fdatasync on Linux 2.6.33+