Re: [PATCH] New [relation] option engine - Mailing list pgsql-hackers

From Nikolay Shaplov
Subject Re: [PATCH] New [relation] option engine
Date
Msg-id 5892085.MhkbZ0Pkbq@thinkpad-pgpro
Whole thread Raw
In response to Re: [PATCH] New [relation] option engine  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] New [relation] option engine
List pgsql-hackers
В письме от пятница, 8 декабря 2023 г. 08:59:41 MSK пользователь Michael
Paquier написал:

> > I've rebased patch, so it could be add to commitfest again.
>
> This is a 270kB patch with quite a few changes, and a lot of code
>
> moved around:
> >  47 files changed, 2592 insertions(+), 2326 deletions(-)
>
> Could it be possible to split that into more successive steps to ease
> its review?

Theoretically I can create patch with full options.c as it is in the patch
now, and use that code only in index AM, and keep reloption.c mostly
unchanged.

This will be total mess with two different options mechanisms working in the
same time, but this might be much more easy to review.  When we are done with
the first step, we can change the rest.
If this will help to finally include patch into postgres, I can do it. Will
that help you to review?


--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum
Next
From: Alvaro Herrera
Date:
Subject: Re: GUC names in messages