On 15.10.25 17:58, Srirama Kucherlapati wrote:
> Main AIX changes patch - 0001-Changes-to-add-support-for-
> AIX.v9.pg19.patch (previously submitted one)
>
> Meson AIX changes patch - 0001-AIX-changes-for-meson-build.patch
>
> Looking forward to hearing your thoughts on these changes.
>
> Your feedback on these updates is highly valued.
The largest problem I see in this patch set is that you are making
unexplained changes in src/include/storage/s_lock.h. The code that you
are changing does not only affect AIX but also PPC with other operating
systems. AFAICT, the change you are proposing does not correspond to
the commit that removed AIX support.
Maybe the proposed changes are beneficial for other operating systems as
well. But in that case, propose this as a separate patch in a separate
thread, with supporting information (and probably benchmarks in this case).
If not, then you need to find a way to make this work on AIX without
materially changing the code that exists for already-supported operating
systems.
