Re: pg_restore -F bug - Mailing list pgsql-patches

From Tom Lane
Subject Re: pg_restore -F bug
Date
Msg-id 5870.1114785643@sss.pgh.pa.us
Whole thread Raw
In response to pg_restore -F bug  (Neil Conway <neilc@samurai.com>)
Responses Re: pg_restore -F bug
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> This patch fixes a bug in the error message emitted by pg_restore on an
> incorrect -F argument: write_msg() expects its first parameter to be a
> "module name", not the format string. Patch applied to HEAD. Is this
> worth backporting?

Certainly --- particularly if the error makes it dump core, as seems
likely (haven't tried it).

> BTW, is there a reason that pg_restore seems to accept 'f', 't', or 'c'
> parameters to this argument, but the documentation only documents 't'
> and 'c'?

I think the 'f' option is only intended for debugging purposes ...
Philip would know ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [INTERFACES] bcc32 libpq compile problem
Next
From: Neil Conway
Date:
Subject: Re: pg_restore -F bug