Re: Removing dependency to wsock32.lib when compiling code on WIndows - Mailing list pgsql-hackers

From MauMau
Subject Re: Removing dependency to wsock32.lib when compiling code on WIndows
Date
Msg-id 5825BAEFFB2A4857B0C9DB7DD112B1CE@maumau
Whole thread Raw
In response to Re: Removing dependency to wsock32.lib when compiling code on WIndows  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Removing dependency to wsock32.lib when compiling code on WIndows  (Michael Paquier <michael.paquier@gmail.com>)
Re: Removing dependency to wsock32.lib when compiling code on WIndows  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
From: "Michael Paquier" <michael.paquier@gmail.com>
> You are right, I only though about the MS scripts when working on this
> patch. Updated patch for a complete cleanup is attached (note I
> updated manually ./configure for test purposes and did not re-run
> autoconf).

I marked this patch as ready for committer.  I confirmed:

* The patch content is correct.

* The patch applies cleanly.  Running "grep -lir wsock32 ." after applying 
the patch shows that wsock32.lib is no longer used.

* The binaries can be built with MSVC 2008 Express.  I didn't try to build 
on MinGW.

* The regression tests pass ("vcregress check").

However, I wonder if some DLL entries in dlls[] in 
src/interfaces/libpq/win32.c should be removed.  winsock.dll should 
definitely be removed, because it is for 16-bit applications.  I don't know 
about the rest.  Especially,  wsock32n.dll and mswsock.dll may also be 
obsolete libraries from their names.  Could you look into this and revise 
the patch if possible?  But I don't mind if you do so.

Regards
MauMau




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: IMPORT FOREIGN SCHEMA statement
Next
From: Kevin Grittner
Date:
Subject: Re: calculation for NUM_FIXED_LWLOCKS