Re: Reject HEADER with binary and json COPY formats by option presence - Mailing list pgsql-hackers

From Chao Li
Subject Re: Reject HEADER with binary and json COPY formats by option presence
Date
Msg-id 58239424-7C23-4E11-9EB4-B03651253E0E@gmail.com
Whole thread
In response to Re: Reject HEADER with binary and json COPY formats by option presence  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers

> On Jun 3, 2026, at 14:55, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Jun 3, 2026 at 2:24 PM Shinya Kato <shinya11.kato@gmail.com> wrote:
>>
>> On Sun, May 31, 2026 at 10:57 AM Chao Li <li.evan.chao@gmail.com> wrote:
>>
>>> While testing “file_fdw: Support multi-line HEADER option”, I noticed a small issue.
>>
>> Thanks for reporting this!
>
> I'm not yet convinced that this needs a code change. We already seem to have
> both styles today: some options are rejected based on their presence,
> while others are effectively judged based on whether the specified value
> actually enables the feature. I don't think we have a clear rule that
> everything should be presence-based.
>
> Regards,
>
> --
> Fujii Masao

Okay, I withdraw this patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add a statistics view to track usage of deprecated features
Next
From: Michael Paquier
Date:
Subject: Re: DOCS - "Get Object DDL Functions" table improvements