Re: (PATCH) Adding CORRESPONDING (NULL error) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: (PATCH) Adding CORRESPONDING (NULL error)
Date
Msg-id 5792.1319749495@sss.pgh.pa.us
Whole thread Raw
In response to (PATCH) Adding CORRESPONDING to Set Operations  (Kerem Kat <keremkat@gmail.com>)
List pgsql-hackers
Kerem Kat <keremkat@gmail.com> writes:
> On Thu, Oct 27, 2011 at 23:20, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> BTW, just to clarify: although that case fails, the case Erik was
>> complaining of does work in unmodified Postgres:
>> ...
>> and I agree with him that it should still work with CORRESPONDING.

> That is by design, because CORRESPONDING is implemented as subqueries:

Well, this appears to me to be a counterexample sufficient to refute
that implementation decision.  You can inject subqueries at plan time,
if that helps you make things match up, but you can't rearrange things
that way at parse time, as I gather you're doing or else you would not
be seeing this problem.  In any case, I already pointed out to you that
rearranging the parse tree that way is problematic for reverse-listing
the parse tree.  We don't want to see subqueries injected in the results
of printing parse trees with ruleutils.c.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: (PATCH) Adding CORRESPONDING (NULL error)
Next
From: Bruce Momjian
Date:
Subject: Re: pg_dumpall Sets Roll default_tablespace Before Creating Tablespaces