On 9/17/19 4:10 PM, Peter Eisentraut wrote:
> On 2019-09-17 21:55, Jonathan S. Katz wrote:
>>> * Encrypted TCP/IP connections using GSSAPI encryption
>>
>> +1, though I would s/GSSAPI encryption/ with s/GSSAPI authentcation/
>
> But you're not encrypting the communication using GSSAPI authentication,
> you're encrypting it using GSSAPI encryption.
Ah, I also did a s/using/for/ in my head, but that's still not correct.
+1 to your suggested wording with no alterations.
>>>> * Discovery of LDAP servers if PostgreSQL is built with OpenLDAP
>>>
>>> I would remove the "if" part from the major features list, since it's a
>>> qualification of minor importance. Instead I'd write something like
>>>
>>> * Discovery of LDAP servers using DNS SRV
>>>
>>> which is a clearer concept that people can easily recognize.
>>
>> I agree it's clearer, I'm not sure if the OpenLDAP semantic above
>> changes things? I'm not sure the relative frequency of PostgreSQL being
>> built with OpenLDAP vs. other LDAP libs.
>
> I suppose it's not-Windows vs. Windows.
>
> It's OK if we mention OpenLDAP in the release notes, but it doesn't seem
> to belong in the major features section.
Well, if you're a Windows user, you may then be disappointed later on to
find out it does not work :)
That said, I'm ok with the more concise wording.
Jonathan
