Re: Where's the docs? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Where's the docs?
Date
Msg-id 5764.1256737428@sss.pgh.pa.us
Whole thread Raw
In response to Re: Where's the docs?  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> On Wed, 2009-10-28 at 00:25 -0400, Tom Lane wrote:
>> Josh Berkus <josh@agliodbs.com> writes:
>>> OK, this is the genuine failure; the syntax is missing for column triggers:

>>> CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
>>> ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
>>> EXECUTE PROCEDURE function_name ( arguments )

>> It's embedded in "event", which isn't spelled out here.

> I know this is a bit suboptimal, but I couldn't think of a better way
> without cluttering up to many things.

Expanding "event" in-place definitely wouldn't be very readable.  The
only alternative that seems sane is to do something like what we do
in SELECT:
CREATE TRIGGER ...
where "event" is:
INSERT | UPDATE [ ( column [,...] ) ] | DELETE | TRUNCATE

I am not convinced that it's worth it, but maybe.  Certainly the current
psql "\h CREATE TRIGGER" display is not helpful at reminding you where
to put the column names.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: SE-PgSQL developer documentation (Re: Reworks for Access Control facilities (r2363))
Next
From: KaiGai Kohei
Date:
Subject: Re: SE-PgSQL developer documentation (Re: Reworks for Access Control facilities (r2363))