Re: Giving more detail in pg_upgrade errormessage - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Giving more detail in pg_upgrade errormessage
Date
Msg-id 57271.1689696260@sss.pgh.pa.us
Whole thread Raw
In response to Giving more detail in pg_upgrade errormessage  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Giving more detail in pg_upgrade errormessage
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> Looking at the upgrade question in [0] made me realize that we discard
> potentially useful information for troubleshooting.  When we check if the
> cluster is properly shut down we might as well include the status from
> pg_controldata in the errormessage as per the trivial (but yet untested)
> proposed diff.

> Is there a reason not to be verbose here as users might copy/paste this output
> when asking for help?

Agreed, but I think you need to chomp the string's trailing newline,
or it'll look ugly.  You might as well do that further up and remove
the newlines from the comparison strings, too.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: remaining sql/json patches
Next
From: Alvaro Herrera
Date:
Subject: Re: Inefficiency in parallel pg_restore with many tables