Re: s/pg_attribute_always_inline/pg_always_inline/? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: s/pg_attribute_always_inline/pg_always_inline/?
Date
Msg-id 56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org
Whole thread Raw
In response to s/pg_attribute_always_inline/pg_always_inline/?  (Andres Freund <andres@anarazel.de>)
Responses Re: s/pg_attribute_always_inline/pg_always_inline/?
List pgsql-hackers
On 08.04.26 23:09, Andres Freund wrote:
> Hi,
> 
> When reviewing the index prefetching patch I got a bit dismayed at how long
> pg_attribute_always_inline is due to the way it triggers pgindent to format
> stuff.
> 
> I propose that we remove the _attribute_ part of the name.
> 
> Given that it is implemented for compilers that don't use the
> __attribute__((always_inline)) spelling, so the shorter name seems better
> anyway.

Yes, and the existing name is also kind of wrong even on GCC because the 
macro does not expand to only an attribute but also includes the "inline".




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Our ABI diff infrastructure ignores enum SysCacheIdentifier
Next
From: Michael Paquier
Date:
Subject: Re: pgstat vs aset