Re: syslog configurable line splitting behavior - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: syslog configurable line splitting behavior
Date
Msg-id 56E92DC0.4080808@proxel.se
Whole thread Raw
In response to Re: syslog configurable line splitting behavior  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On 03/16/2016 03:50 AM, Peter Eisentraut wrote:
> On 3/8/16 9:12 PM, Andreas Karlsson wrote:
>> I have one nitpick: why is one of the variables "true" while the other
>> is "on" in the example? I think both should be "on".
>>
>> #syslog_sequence_numbers = true
>> #syslog_split_lines = on
>>
>> Another possible improvement would be to change "Split messages sent to
>> syslog." to something more verbose like "Split messages sent to syslog,
>> by lines and to fit in 1024 bytes.".
>
> Updated patches with your suggestions.  I also renamed
> syslog_split_lines to syslog_split_messages, which I think is more accurate.

I think the patch looks good now. I will change the status to "Ready for 
committer".

Andreas




pgsql-hackers by date:

Previous
From: "Constantin S. Pan"
Date:
Subject: Re: [WIP] speeding up GIN build with parallel workers
Next
From: Craig Ringer
Date:
Subject: Re: WIP: Failover Slots