Re: Minor bug affecting ON CONFLICT lock wait log messages - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Minor bug affecting ON CONFLICT lock wait log messages
Date
Msg-id 56E8028A.60806@dalibo.com
Whole thread Raw
In response to Re: Minor bug affecting ON CONFLICT lock wait log messages  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Minor bug affecting ON CONFLICT lock wait log messages
List pgsql-hackers
On 15/03/2016 03:30, Peter Geoghegan wrote:
> On Mon, Mar 7, 2016 at 1:46 PM, Peter Geoghegan <pg@heroku.com> wrote:
>> Attached patch fixes a bug reported privately by Stephen this morning.
> 
> Bump.
> 
> I would like to see this in the next point release. It shouldn't be
> hard to review.
> 

+            reason_wait = indexInfo->ii_ExclusionOps ?
+                XLTW_RecheckExclusionConstr : XLTW_InsertIndex;

Shouldn't it be set to XLTW_InsertIndexUnique instead?


Otherwise the patch seems ok to me.

> Thanks
> 


-- 
Julien Rouhaud
http://dalibo.com - http://dalibo.org



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Timeline following for logical slots
Next
From: Craig Ringer
Date:
Subject: Re: Timeline following for logical slots