Re: Refectoring of receivelog.c - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: Refectoring of receivelog.c
Date
Msg-id 56E4A302.90601@2ndquadrant.com
Whole thread Raw
In response to Re: Refectoring of receivelog.c  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Refectoring of receivelog.c
List pgsql-hackers
On 03/11/2016 11:15 AM, Magnus Hagander wrote:
>
...
>
>
> Pushed with updated comments and a named stsruct.

Pretty sure this memset call in pg_basebackup.c is incorrect, as it 
passes parameters in the wrong order:
    MemSet(&stream, sizeof(stream), 0);

It seems benign, because we're setting all the fields explicitly, but 
gcc is nagging about it.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [GENERAL] OS X 10.11.3, psql, bus error 10, 9.5.1
Next
From: Chris Ruprecht
Date:
Subject: Re: [GENERAL] OS X 10.11.3, psql, bus error 10, 9.5.1