Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan
Date
Msg-id 56B176D0.30504@lab.ntt.co.jp
Whole thread Raw
In response to Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2016/02/03 3:31, Alvaro Herrera wrote:
> Etsuro Fujita wrote:
>
>> Done.  Attached is an updated version of the patch.
>
> Pushed, thanks.

Thank you!

> I kinda wonder why this struct member has a name that doesn't match the
> naming convention in the rest of the struct, and also why isn't it
> documented in the comment above the struct definition.  But that's not
> this patch's fault.

I think so, too.

Best regards,
Etsuro Fujita





pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: [POC] FETCH limited by bytes.
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Incorrect formula for SysV IPC parameters