On 2/1/16 4:59 PM, Alvaro Herrera wrote:
> Masahiko Sawada wrote:
>
>> Attached updated version patch.
>> Please review it.
>
> In pg_upgrade, the "page convert" functionality is there to abstract
> rewrites of pages being copied; your patch is circumventing it and
> AFAICS it makes the interface more complicated for no good reason. I
> think the real way to do that is to write your rewriteVisibilityMap as a
> pageConverter routine. That should reduce some duplication there.
IIRC this is about the third problem that's been found with pg_upgrade
in this patch. That concerns me given the potential for disaster if
freeze bits are set incorrectly.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
