Copy-pasto in the ExecForeignDelete documentation - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Copy-pasto in the ExecForeignDelete documentation
Date
Msg-id 56AF32B9.4060204@lab.ntt.co.jp
Whole thread Raw
Responses Re: Copy-pasto in the ExecForeignDelete documentation
List pgsql-hackers
Hi,

While working on FDW DML pushdown, I ran into a copy-pasto in the
ExecForeignDelete documentation in fdwhandler.sgml:

     The data in the returned slot is used only if the <command>DELETE</>
     query has a <literal>RETURNING</> clause or the foreign table has
     an <literal>AFTER ROW</> trigger.  Triggers require all columns,
but the

I don't think the data is referenced by the AFTER ROW DELETE triggers.
Attached is a patch to fix that.  The patch also avoids adding an
unnecessary RETURNING clause to DELETE when deparsing a remote DELETE
statement in postgres_fdw.

I'll add this to the next CF.

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics
Next
From: Magnus Hagander
Date:
Subject: Re: Comment typos in source code: s/thats/that is/