Re: Improve pg_sync_replication_slots() to wait for primary to advance - Mailing list pgsql-hackers

From Chao Li
Subject Re: Improve pg_sync_replication_slots() to wait for primary to advance
Date
Msg-id 56A9D432-28C9-4954-B3D0-2CCBCF74909F@gmail.com
Whole thread Raw
In response to Re: Improve pg_sync_replication_slots() to wait for primary to advance  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers

> On Dec 10, 2025, at 20:23, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Dec 10, 2025 at 10:37 AM Ajin Cherian <itsajin@gmail.com> wrote:
>>
>> Attaching v34 addressing the above comments.
>>
>
> 0001 looks mostly good to me. I have made minor edits in the comments
> and added error_code for one of the error messages. Please check
> attached and let me know what you think?
>
> --
> With Regards,
> Amit Kapila.
> <v35-0001-Signal-backends-running-pg_sync_replication_slot.patch>

I saw you have integrated the missed change from the last push into v35, and v35 looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_plan_advice
Next
From: Heikki Linnakangas
Date:
Subject: Re: Improve comment in function GetPublicationRelations