On 01/19/2016 09:02 AM, Bruce Momjian wrote:
>>>>> Ok. Notwithstanding Simon's reply, there seems to be consensus that this
>>>>> is the way to go. Will commit it this way unless some additional
>>>>> objections surface in the next day or so.
>>>>
>>>> FYI, this slash-colon change will break pg_upgrade unless it is patched.
>>>> Dp you want a patch from me?
>>>
>>> Didn't realize that -- yes please.
>>
>> Sure, attached, and it would be applied only to head, where you change
>> pg_controldata. pg_upgrade has to read the old and new cluster's
>> pg_controldata. We could get more sophisticated by checking the catalog
>> version number where the format was changed, but that doesn't seem worth
>> it, and is overly complex because we get the catalog version number from
>> pg_controldata, so you would be adding a dependency in ordering of the
>> pg_controldata entries.
>
> Sorry, please use the attached patch instead, now tested with your
> changes.
The attached includes Bruce's change, plus I found two additional sites
that appear to need the same change. The xlog.c change is just a DEBUG
message, so not a big deal. I'm less certain if the xlogdesc.c change
might create some fallout.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
