CleanHelpPath & index.html - Mailing list pgadmin-hackers

From Andreas 'ads' Scherbaum
Subject CleanHelpPath & index.html
Date
Msg-id 568D8B8A.10804@wars-nicht.de
Whole thread Raw
Responses Re: CleanHelpPath & index.html  (Andreas 'ads' Scherbaum <adsmail@wars-nicht.de>)
List pgadmin-hackers
Hi,

looking into misc.cpp, around line 661, there is CleanHelpPath. When I
try to add a documentation link ending with "index.html", this function
incorrectly assumes that it must be a directory and adds a "/" (or
whatever the current separator is).

This even happens when the correct link is in ~/.pgadmin3. The link is
then read from the config file, cleaned up incorrectly and when I try to
open the help link, it points to the wrong URL (index.html/).

Attached is a small patch which checks a string in CleanHelpPath if it
ends in one of the most common file types (.htm, .html, .php and .asp)
and if this is the case, the string is returned as is.


Regards,

--
                Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Resolved an issue in the sesion tracking, and generat
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Stringify the data only during GET mode.