Doubled test for SET statements in pg_stat_statements tests - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Doubled test for SET statements in pg_stat_statements tests
Date
Msg-id 5689421699428803@mail-sendbernar-production-main-46.myt.yp-c.yandex.net
Whole thread Raw
Responses Re: Doubled test for SET statements in pg_stat_statements tests
List pgsql-hackers
Hello!

I noticed that the same block

-- SET statements.
-- These use two different strings, still they count as one entry.
SET work_mem = '1MB';
Set work_mem = '1MB';
SET work_mem = '2MB';
RESET work_mem;
SET enable_seqscan = off;
SET enable_seqscan = on;
RESET enable_seqscan;

is checked twice in contrib/pg_stat_statements/sql/utility.sql on lines 278-286 and 333-341. Is this on any purpose? I
thinkthe second set of tests is not needed and can be removed, as in the attached patch.
 

regards, Sergei
Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: ensure, not insure
Next
From: Bharath Rupireddy
Date:
Subject: Re: Show WAL write and fsync stats in pg_stat_io