Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates
Date
Msg-id 5664F98A.3030107@proxel.se
Whole thread Raw
In response to Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates  (Peter Geoghegan <pg@heroku.com>)
Responses Re: Re: Reusing abbreviated keys during second pass of ordered [set] aggregates  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Hi,

I have reviewed this patch and it still applies to master, compiles and 
passes the test suite.

I like the goal of the patch, making use of the already existing 
abbreviation machinery in more cases is something we should do and the 
patch itself looks clean.

I can also confirm the roughly 25% speedup in the best case (numerics 
which are all distinct) with no measurable slowdown in the worst case.

Given this speedup and the small size of the patch I think we should 
apply it. I will set this patch to "Ready for Commiter".

Andreas



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: pglogical_output - a general purpose logical decoding output plugin
Next
From: Craig Ringer
Date:
Subject: Re: Logical replication and multimaster