Re: WIP: Covering + unique indexes. - Mailing list pgsql-hackers

From Anastasia Lubennikova
Subject Re: WIP: Covering + unique indexes.
Date
Msg-id 5661C6A0.2020602@postgrespro.ru
Whole thread Raw
In response to Re: WIP: Covering + unique indexes.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

03.12.2015 04:03, Robert Haas пишет:
> On Tue, Dec 1, 2015 at 7:53 AM, Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> If we don't need c4 as an index scankey, we don't need any btree opclass on
>> it.
>> But we still want to have it in covering index for queries like
>>
>> SELECT c4 FROM tbl WHERE c1=1000; // uses the IndexOnlyScan
>> SELECT * FROM tbl WHERE c1=1000; // uses the IndexOnlyScan
>>
>> The patch "optional_opclass" completely ignores opclasses of included
>> attributes.
> OK, I don't get it.  Why have an opclass here at all, even optionally?

We haven't opclass on c4 and there's no need to have it.
But now (without a patch) it's impossible to create covering index, 
which contains columns with no opclass for btree.

test=# create index on tbl using btree (c1, c4);
ERROR:  data type box has no default operator class for access method 
"btree"

ComputeIndexAttrs() processes the list of index attributes and trying to 
get an opclass for each of them via GetIndexOpClass().
The patch drops this check for included attributes. So it makes possible 
to store any datatype in btree  and use IndexOnlyScan advantages.

I hope that this helps to clarify.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Random crud left behind by aborted TAP tests
Next
From: Geoff Winkless
Date:
Subject: Re: Remaining 9.5 open items