Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows - Mailing list pgsql-hackers

From Bryan Green
Subject Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows
Date
Msg-id 56600fbb-d3b1-4547-8277-f9d3fb694e52@gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On 1/20/2026 2:39 PM, Peter Eisentraut wrote:
> On 08.01.26 15:57, Bryan Green wrote:
>> I agree with the above changes and have implemented them, including the
>> correction to the cutoff version.  But, before sharing the patch with
>> those changes I think we should discuss 1) should we short-circuit
>> C/POSIX and not ever call gettext in that case,
> 
> You had written that you had submitted a patch to gettext to handle that
> there.  Has that gotten anywhere?
> 
>> 2) should we try to
>> convert "ISO" to Windows legacy format.
> 
> I don't know.  We can just tell users to set their locale in the right
> format.
Peter,
I have attached the patch with the changes you suggested/requested.  The
patch was added to gnulib in December.  The latest release of gnu
gettext (1.0) does include the patch.  Yes, they jumped from 0.26 to 1.0.

-- 
Bryan Green
EDB: https://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Manni Wood
Date:
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD
Next
From: Tom Lane
Date:
Subject: Re: AIX support