Re: What's the point of json_extract_path_op etc? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: What's the point of json_extract_path_op etc?
Date
Msg-id 56418.1403809896@sss.pgh.pa.us
Whole thread Raw
In response to Re: What's the point of json_extract_path_op etc?  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: What's the point of json_extract_path_op etc?  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 06/25/2014 02:46 PM, Tom Lane wrote:
>> Why do we have essentially duplicate pg_proc entries for json_extract_path
>> and json_extract_path_op?
>> Likewise for json_extract_path_text_op, jsonb_extract_path_op, and
>> jsonb_extract_path_text_op.

> ISTR trying that and running into problems, maybe with opr_sanity checks.

Well, the reason that opr_sanity is complaining is that there's a
violation of our general policy of documenting either the operator or
the underlying function, not both.  Using a separate pg_proc entry
like this doesn't mean you didn't violate the policy; you just hid the
violation from opr_sanity.

Do we actually want to document these things as both operators and
functions?  If we do, then the right answer is to list them as known
exceptions in the opr_sanity test, not to hide the fact that we're
violating the general documentation policy.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: better atomics - v0.5
Next
From: Merlin Moncure
Date:
Subject: Re: better atomics - v0.5