Re: BRIN INDEX value - Mailing list pgsql-hackers

From Amit Langote
Subject Re: BRIN INDEX value
Date
Msg-id 55E926C0.90907@lab.ntt.co.jp
Whole thread Raw
In response to Re: BRIN INDEX value  (Tatsuo Ishii <ishii@postgresql.org>)
Responses Re: BRIN INDEX value  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
On 9/4/2015 2:04 PM, Tatsuo Ishii wrote:
>> One thing I imagine we could do is to change the signature of
>> summrize_range() to also include heapNumBlks which its (only) caller
>> brinsummarize() already computes. It will look like:
>>
>> static void summarize_range(IndexInfo *indexInfo, BrinBuildState *state,
>>                               Relation heapRel,
>>                               BlockNumber heapBlk,
>>                               BlockNumber heapNumBlks);
>>
>> I'd think changing summarize_range()'s signature would be relatively
>> easier/safer.
>
> Yeah, sounds good.

Here's a patch to do that.

Thanks,
Amit

Attachment

pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: BRIN INDEX value
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: pgbench - allow backslash-continuations in custom scripts