Re: Extended test coverage and docs for SSL passphrase commands - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Extended test coverage and docs for SSL passphrase commands
Date
Msg-id 55D58873-1507-4272-9402-B2110D84EB8D@yesql.se
Whole thread Raw
In response to Re: Extended test coverage and docs for SSL passphrase commands  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
> On 22 Nov 2025, at 10:30, Chao Li <li.evan.chao@gmail.com> wrote:

> I just reviewed the patch and got a few comments.

Thanks! An updated version will come downthread.

> The GUC is added like a mirror of debug_assertions. However, I think a small difference is that, assertions will
impacteverything at runtime, while EXEC_BACKEND don’t really impact PG’s behavior, instead it only impacts how backend
processesare spawned. Thus, I feel “running server is EXEC_BACKEND mode” is a little bit inaccurate, maybe just say
“showwhether the running server is built with EXEC_BACKEND”. 

That's a good point, the docementation hunk had it right where this part got it
wrong.  Fixed.

> This is not a comment. I’m just thinking that, as EXEC_BACKEND is compile flag, when a server is started, it knows if
EXEC_BACKENDis enabled or not. So that, if ssl_passphrase_command must be turned on, why cannot we automatically turn
onit? 

Technically we might be able to, but I don't want to override the administrator
when it comes to sensitive configuration settings.  Better to document what
needs to be done and have the user make informed decisions.

> Typo: passhprase -> passphrase

Fixed.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Trying out
Next
From: Daniel Gustafsson
Date:
Subject: Re: Extended test coverage and docs for SSL passphrase commands