Re: Improving test coverage of extensions with pg_dump - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: Improving test coverage of extensions with pg_dump
Date
Msg-id 55B93D9F.7060709@proxel.se
Whole thread Raw
In response to Re: Improving test coverage of extensions with pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Improving test coverage of extensions with pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
I have reviewed this patch and it compiles runs and the new test case 
passes. The code is also clean and the test seems like a useful 
regression test.

What I do not like though is how the path src/test/tables_fk/t/ tells us 
nothing about what features are of PostgreSQL are tested here. For this 
I personally prefer the earlier versions where I think that was clear.

Another though: would it be worthwhile to also add an assertion to check 
if the data really was restored properly or would that just be redundant 
code?

-- 
Andreas



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: dblink: add polymorphic functions.
Next
From: Joe Conway
Date:
Subject: Re: more RLS oversights