Re: Microvacuum for gist. Question about GISTPageOpaqueData flag - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: Microvacuum for gist. Question about GISTPageOpaqueData flag
Date
Msg-id 55B6526F.9050409@sigaev.ru
Whole thread Raw
In response to Microvacuum for gist. Question about GISTPageOpaqueData flag  (Anastasia Lubennikova <lubennikovaav@gmail.com>)
Responses Re: Microvacuum for gist. Question about GISTPageOpaqueData flag
List pgsql-hackers
> I need an advice, what would be better:
> - to add new flag like F_HAS_GARBAGE,
> - or to delete all mentions of F_TUPLES_DELETED and use it in gist microvacuum.

According to commit message:
commit 2effb72e682a7dbdc9a8a60a80c22ec1fa9d8079
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:   Fri Nov 7 15:03:46 2014 +0200
..    The code that generated a record to clear the F_TUPLES_DELETED flag hasn't    existed since we got rid of
old-styleVACUUM FULL. I kept the code that sets    the flag, although it's not used for anything anymore, because it
might   still be interesting information for debugging purposes that some tuples    have been deleted from a page.
 
..

If Heikki doesn't change his opinion then introduce new flag. Although I don't 
think that we need to keep F_TUPLES_DELETED.


Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: optimizing vacuum truncation scans
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench - allow backslash-continuations in custom scripts