fdw_scan_tlist for foreign table scans breaks EPQ testing, doesn't it? - Mailing list pgsql-hackers

From Etsuro Fujita
Subject fdw_scan_tlist for foreign table scans breaks EPQ testing, doesn't it?
Date
Msg-id 55AF3C08.1070409@lab.ntt.co.jp
Whole thread Raw
Responses Re: fdw_scan_tlist for foreign table scans breaks EPQ testing, doesn't it?  (Kouhei Kaigai <kaigai@ak.jp.nec.com>)
List pgsql-hackers
Hi,

The latest foreign-join pushdown patch allows fdw_scan_tlist to be set
to a targetlist even for simple foreign table scans.  However, since I
think we assume that the test tuple of a foreign table for an EPQ
testing, whether it may be copied from the whole-row var or returned by
the RefetchForeignRow routine, has the rowtype declared for the foreign
table, ISTM that EPQ testing doesn't work properly in such a case since
that the targetlist and qual are adjusted to reference fdw_scan_tlist in
such a case.  Maybe I'm missing something though.

I don't understand custom scans/joins exactly, but I have a similar
concern for the simple-custom-scan case too.

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: WAL logging problem in 9.4.3?
Next
From: Etsuro Fujita
Date:
Subject: Re: Typo in comment in setrefs.c