Re: pgbench - allow backslash-continuations in custom scripts - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: pgbench - allow backslash-continuations in custom scripts
Date
Msg-id 55846B78.8000809@agliodbs.com
Whole thread Raw
In response to pgbench - allow backslash-continuations in custom scripts  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pgbench - allow backslash-continuations in custom scripts  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On 06/19/2015 02:51 PM, Tom Lane wrote:
> Josh Berkus <josh@agliodbs.com> writes:
>> On 05/14/2015 12:10 PM, Fabien COELHO wrote:
>>> Add backslash continuations to pgbench custom scripts.
> 
>> I don't personally agree.  I believe that it it worth breaking backwards
>> compatibility to support line breaks in pgbench statements, and that if
>> we're not going to do that, supporting \ continuations is of little value.
> 
> I tend to agree on that bottom line; having this be inconsistent with psql
> does not seem like a win.
> 
>> I'm not clear on why we'd need a full SQL lexer.
> 
> So you don't get fooled by semicolons embedded in string literals or
> comments.

I take it we ignore those now?  I mean, personally, it wouldn't break
anything for me but since some other benhcmarks involve random text
generators ....


-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: The real reason why TAP testing isn't ready for prime time
Next
From: Tomas Vondra
Date:
Subject: Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H