Re: [PATCH] New [relation] option engine - Mailing list pgsql-hackers

From Nikolay Shaplov
Subject Re: [PATCH] New [relation] option engine
Date
Msg-id 55843546.Gl5gMapaBX@thinkpad-pgpro
Whole thread Raw
In response to Re: [PATCH] New [relation] option engine  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
В письме от среда, 1 февраля 2023 г. 12:04:26 MSK пользователь Alvaro Herrera
написал:
> On 2023-Jan-31, vignesh C wrote:
> > On Tue, 3 Jan 2023 at 18:38, vignesh C <vignesh21@gmail.com> wrote:
> > > The patch does not apply on top of HEAD as in [1], please post a rebased
> > > patch: === Applying patches on top of PostgreSQL commit ID
> > > 92957ed98c5c565362ce665266132a7f08f6b0c0 ===
> > > === applying patch ./new_options_take_two_v03f.patch
> > > patching file src/include/access/reloptions.h
> > > Hunk #1 FAILED at 1.
> > > 1 out of 4 hunks FAILED -- saving rejects to file
> > > src/include/access/reloptions.h.rej
> >
> > There has been no updates on this thread for some time, so this has
> > been switched as Returned with Feedback. Feel free to open it in the
> > next commitfest if you plan to continue on this.
>
> Well, no feedback has been given, so I'm not sure this is a great
> outcome.  In the interest of keeping it alive, I've rebased it.  It
> turns out that the only conflict is with the 2022 -> 2023 copyright line
> update.
>
> I have not reviewed it.
Guys sorry, I am totally unable to do just anything this month... Do not have
spare resources to switch my attention to anything even this simple...

Hope, next month will be better... And I will try to do some more reviewing of
other patches...

--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [DOCS] Stats views and functions not in order?
Next
From: Amit Kapila
Date:
Subject: Re: Exit walsender before confirming remote flush in logical replication