Re: [PATCH] Increase the maximum value track_activity_query_size - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Increase the maximum value track_activity_query_size
Date
Msg-id 556.1576771167@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Increase the maximum value track_activity_query_size  (Bruce Momjian <bruce@momjian.us>)
Responses Re: [PATCH] Increase the maximum value track_activity_query_size  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Good question.  I am in favor of allowing a larger value if no one
> objects.  I don't think adding the min/max is helpful.

I think there are pretty obvious performance and memory-consumption
penalties to very large track_activity_query_size values.  Who exactly
are we really helping if we let them set it to huge values?

(wanders away wondering if we have suitable integer-overflow checks
in relevant code paths...)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Remove twice assignment with var pageop (nbtree.c).
Next
From: Andres Freund
Date:
Subject: Re: Read Uncommitted