Re: pgsql: At promotion, archive last segment from old timeline with .parti - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: At promotion, archive last segment from old timeline with .parti
Date
Msg-id 555F53D0.7050506@gmx.net
Whole thread Raw
In response to pgsql: At promotion, archive last segment from old timeline with .parti  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
List pgsql-committers
On 5/8/15 3:07 PM, Heikki Linnakangas wrote:
> At promotion, archive last segment from old timeline with .partial suffix.

There appears to be a mixup here:

+               char        origpath[MAXPGPATH];
+               char        partialfname[MAXFNAMELEN];
+               char        partialpath[MAXPGPATH];
+
+               XLogFilePath(origpath, EndOfLogTLI, endLogSegNo);
+               snprintf(partialfname, MAXPGPATH, "%s.partial", origfname);
+               snprintf(partialpath, MAXPGPATH, "%s.partial", origpath);

Some compilers are complaining that the snprintf(partialfname, ...)
could overflow.



pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Unpack jbvBinary objects passed to pushJsonbValue
Next
From: Tom Lane
Date:
Subject: pgsql: Fix recently-introduced crash in array_contain_compare().