Re: pgsql: Make hstore_plperl's build even more like plperl's - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: Make hstore_plperl's build even more like plperl's
Date
Msg-id 5544BD8A.5050802@gmx.net
Whole thread Raw
In response to Re: pgsql: Make hstore_plperl's build even more like plperl's  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Make hstore_plperl's build even more like plperl's
List pgsql-committers
On 5/2/15 4:32 AM, Andrew Dunstan wrote:
>
>
>
>
> On 05/01/2015 10:20 PM, Peter Eisentraut wrote:
>> Make hstore_plperl's build even more like plperl's
>>
>> Combine the two places that set CPPFLAGS into one.  Also, some settings
>> should be restricted to Windows only.  More precisely, -Wno-comment is
>> a GCC-only option, but Windows in a makefile implies GCC at the moment.
>>
>> Also, since -Wno-comment is more properly a preprocessor option, move it
>> to CPPFLAGS to simplify things a bit.
>>
>
> Did you actually test this? On my system you have just managed to break
> what I had unbroken.

I have re-fixed my fix.



pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: hstore_plperl: Move port-specific parts to later in the makefile
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Make hstore_plperl's build even more like plperl's