Re: pgsql: Add missing installcheck target to pg_rewind's Makefile - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Add missing installcheck target to pg_rewind's Makefile
Date
Msg-id 55374BA5.2060708@iki.fi
Whole thread Raw
In response to Re: pgsql: Add missing installcheck target to pg_rewind's Makefile  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 04/21/2015 11:38 PM, Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
>> Add missing installcheck target to pg_rewind's Makefile
>
> This patch seems a brick shy of a load, in that "make installcheck" in
> bin/pg_rewind leaves behind a bunch of junk in a tmp_check/ subdirectory.
> installcheck in any other src/bin/ subdirectory doesn't do that.

Ok, fixed.

It would actually be quite useful to leave tmp_check behind if the test
fails, for debugging purposes. Not just in pg_rewind, but in the other
subdirectories too. Another patch for another day..

- Heikki



pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Don't leave 'tmp_check' directory behind in pg_rewind regression
Next
From: Andres Freund
Date:
Subject: pgsql: Rename pg_replication_slot's new active_in to active_pid.