Re: pgsql: Error out in pg_rewind if lstat() fails. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Error out in pg_rewind if lstat() fails.
Date
Msg-id 552F5574.4030701@iki.fi
Whole thread Raw
In response to Re: pgsql: Error out in pg_rewind if lstat() fails.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-committers
On 04/16/2015 04:17 AM, Michael Paquier wrote:
> On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas
> <heikki.linnakangas@iki.fi> wrote:
>> Error out in pg_rewind if lstat() fails.
>>
>> A "file not found" is expected if the source server is running, so don't
>> complain about that. But any other error is definitely not expected.
>
> Nitpicking: strings of pg_fatal need to have a newline '\n' for readability.

Ah, good catch! Fixed.

- Heikki



pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Add missing newlines to error messages.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: MSVC: Include modules of src/test/modules in build